Add power sum problem #8832
Merged
Add power sum problem #8832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
rohan472000
suggested changes
Jun 25, 2023
|
@rohan472000 Please review again, thank you very much 💕. |
algorithms-keeper
bot
added
the
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
backtracking/power_sum.py
Outdated
| sum_ = count_ = 0 | ||
|
|
||
|
|
||
| def backtrack(x: int, n: int, i: int) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: n
Please provide descriptive name for the parameter: i
backtracking/power_sum.py
Outdated
| return | ||
|
|
||
|
|
||
| def solve(x: int, n: int) -> int: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: n
algorithms-keeper
bot
added
awaiting reviews
rohan472000
reviewed
Jun 25, 2023
rohan472000
suggested changes
Jun 25, 2023
algorithms-keeper
bot
removed
the
require descriptive names
algorithms-keeper
bot
removed
the
tests are failing
|
I fixed the issue with ruff 🎊🎊🎊. |
rohan472000
reviewed
Jun 25, 2023
rohan472000
reviewed
Jun 25, 2023
rohan472000
suggested changes
Jun 25, 2023
rohan472000
suggested changes
Jun 25, 2023
|
@cclauss kindly review this PR... |
cclauss
approved these changes
Jun 26, 2023
cclauss
approved these changes
Jun 26, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
algorithms-keeper
bot
added
awaiting reviews
algorithms-keeper
bot
removed
the
awaiting reviews
sedatguzelsemme
pushed a commit
to sedatguzelsemme/Python
that referenced
this pull request
Sep 15, 2024
* Add powersum problem * Add doctest * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add more doctests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add more doctests * Improve paramater name * Fix line too long * Remove global variables * Apply suggestions from code review * Apply suggestions from code review --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Add new solution to a problem named power sum. The problem is from here.
Checklist:
Fixes: #{$ISSUE_NO}.